Karol Majewski

Results 31 comments of Karol Majewski

What should happen if `useSWR` from `swr/suspense` was used alongside a global config contradicting it? ```tsx ```

OK, so your proposal is for the new `useSWR` to override default settings with `{ suspense: true }`. That makes sense. How should then conditional fetching be solved? Suspense users...

@MoSattler There is a problem with such an overload. Reason: `key` being a `string` is not enough to infer that `data` will be defined. Consider this common use case: ```ts...

> How so? Wouldn't the string evaluate to `'/customers/null'`, and SWR would make a call to that non-existing endpoint, propagating the `404` error to be handled by the error boundary?...

It would be wonderful to ignore specific authors/labels. For example: my team has a Slack channel subscribed to pull requests open on GitHub. It's a good reminder that someone is...

Note: if we want to be _really_ pedantic, the accepted props should never accept both `at` and `between`. Or and invalid combination of `lessThan` and `greaterThan`. Instead, `Props` should be...

Hey @zephraph, love the idea! When would you like to do it? 😄

To anyone interested: - [This library](https://github.com/lukezirngibl/msal-react-v2) exposes a React component using the PKCE flow - Early next year, [there should be an official `react-msal` library](https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/2329#issuecomment-697787324)

@Glavin001 It mostly does, thank you! I looked [here](https://github.com/Glavin001/tslint-clean-code/blob/master/src/idLengthRule.ts#L19) and thought `options: null` means there is no config available.