Josh Di Fabio

Results 40 comments of Josh Di Fabio

> I found the decisions quite hard to make at the time I wrote these. I can imagine! This really is an excellent package though and it's clear that a...

I think at this point it's all pretty subjective so I won't attempt to add anything else to the discussion beyond what I've already said. > I would be happy...

> For example, this code from the tests: $this->compare([$year, $month, $day], [ $date->getYear(), $date->getMonth(), $date->getDay() ]); I don't think this is a good example, because you would not typically hold...

Apologies for bringing this up again, as I think we discussed it previously but I can't find where, but what does the following mean in `Loop`? > An unique identifier...

> Unique to the driver, but I guess we need to add that to the docblock. Okay. Now that `Driver` is an abstract class, and not an interface, I think...

Thanks @bwoebi. My idea is similar but includes a driver identifier to highlight situations where the application is attempting to reference a watcher from a different driver instance. > I...

Cheers. I'll do so after work this evening.

What if we ended up with two versions of the uv driver which worked with different versions of the uv extension? Perhaps the drivers which rely on extensions should be...

This would certainly simplify usage. It does raise the question of what the difference between this package and, say, _amphp/loop_ would actually be. Clearly replacing vendor-specific loop packages would be...

Okay. I think I'm on board as well.