Josh Di Fabio
Josh Di Fabio
> Splitting it is stupid, as Driver depends on InvalidWatcherException etc. Good point. I'll make a PR this evening unless someone else does it first.
Apologies, this slipped my mind. I'll provide a PR this afternoon.
I think it would be good if all loop implementations handled these edge cases the same way, including numeric strings such as '1' being passed as delays/intervals. We don't want...
@schnittstabil The functions you propose are both blocking.
Yeah, I guess that'd be more efficient than creating an object for every `when()` call, and more consistent with `Loop` as well.
I agree, that would be a better approach.
Sorry guys, I was replying via email on my phone last night and I missed a bunch of what you said. I'm not sure if I've been clear with what...
@bwoebi Thanks for taking the time to reply in detail. Having considered your point and thought about this for a while I think you're right; this is an edge case...
> it doesn't violate LSP to return a value when the parent returns void I don't think that is true. Non-null types are not subtypes of null. If the return...
> @joshdifabio void ≠ null. It's just PHP which makes void functions return null. void actually means "value irrelevant". I don't agree that void means _value irrelevant_. Void means that...