Jonatan Kłosko

Results 219 comments of Jonatan Kłosko

Hey @LeartS :) We are yet to discuss details of this, but there are a couple other features we prioritize for now.

Comments on selection are complicated, because for Markdown we show the rendered content most of the time. Also, recently we started to introduce new types of cells (smart cells), so...

FTR one option is to handle comments on cell-level, but allow each comment to have an optional editor selection (so the selection is more of an additional info, and removing...

After discussing offline, we agreed that comments should apply to the whole cell, forming a "Discussion". We may also add support for ephemeral, source-related comments, but this is a separate...

Sure, here are the high-level parts * add comments to the notebook data structure, specifically each cell type (`Notebook.Cell.*`) will need a list of comments * add *operations* for adding/removing/editing...

@BasileNouvellet awesome! Feel free to open a PR and we can iterate from there :)

There is a bug that turns this into a relative URL (fixed in #1255). However, with that fixed, the `href` is removed altogether by HTML sanitization given `myurihandler://some/path`. I don't...

I see, there's no specific list of dangerous schemes that we could disallow ([ref](https://security.stackexchange.com/questions/148428/which-url-schemes-are-dangerous-xss-exploitable)). What we can do is have a configuration under settings for enabling specific schemes other than...

@aleDsz awesome job, I left some comments! :cat: