Joel Martinez

Results 89 comments of Joel Martinez

Oh, also ... just for the sake of referencing, this is a fix to #606

@saucecontrol "whatever ms uses for the docs" is [mdoc](https://github.com/mono/api-doc-tools) (which uses cecil's implementation). This is the reason that @hiihellox10 and I are working on this issue 🤣 Thanks for that...

@jbevain I will if it's not resolved by the time the original issue gets prioritized onto my plate ( ;) @mimisasouvanh). Not 100% sure when that will be, but I'll...

Ok, so doing some more investigation on this ... when I debug into the `DocCommentId` class, the `Builder` class's `.ToString()` method returns this: ``` Mono.Cecil.Tests.Test`1/Builder ``` It is a `GenericInstanceType`,...

@jbevain I figured it was something like that. But that then begs the question ... _is roslyn wrong here_? Or should I somehow adjust `DocCommentId` here with some special cases...

Building on this and leaving notes on this gh issue as I go ... I've got an initial fix/implementation working for this scenario, but I'm going to have to continue...

lol, yeah ... I'll make sure to include a number of tests and scenarios once it's implemented (while also double checking against the roslyn results). I don't know exactly when...

So to be clear, what we want here is for protected members to be **excluded** from the repo files, when the class that contains it is `sealed` ?

The only way one of those XML files would ever be created, is if it existed as a type in the assemblies at some point during a previous `mdoc update`...

@lobrien I think we had discussed this over chat, but wanted to add some more context here on the GH issue. Was the root cause here that these `*_Extensions` types...