Edgar Espina comments

Results 135 comments of


                                            Edgar Espina

Freezing and OutOfMemoryError when compiling medium to large sized templates

Thanks, will have a look later (end of the month)

fix in issue #660 was not complete

~~That rule produces a side effect: https://github.com/jknack/handlebars.java/issues/660~~ ~~We need to add the missing window new line character~~

fix in issue #660 was not complete

Sorry, ignore my previous comment (answer too early). Did you excludes windows new line char in your rule? That will do it

block params context is incorrect

don't remember exactly, but think is was bc of handlebars.js

block params context is incorrect

there was a reason.. do me a favor change the childcontext to do a normal `Context`, not a `ParentFirst`. Then run the tests, you will see there some odd use...

block params context is incorrect

I'm surprise it is only one, sadly I copied that tests from handlebarsjs tests :S

block params context is incorrect

:( doesn't make sense, never understand why they did it like this

Inline partial leak - additional scenario

there is no zip file (can't download)

Inline partial leak - additional scenario

I found the issue, but not sure how to fix it yet. It requires time and feel is going to break something else :S

Scala Support

Of course, will wait for pull request. Thanks