Edgar Espina

Results 135 comments of Edgar Espina

@agentgt @imeszaros Going to push a commit with module-info.java in all sub-modules where is possible. For those where isn't... I'm going to add a `Automatic-Module-Name` to MANIFEST. For example: jooby-undertow...

most of them yes, they do. Spring is: ``` requires spring.core; requires spring.beans; requires spring.context; ```

Committed: [aed6de0](https://github.com/jooby-project/jooby/commit/aed6de0e533b4fd85298363d6e49568002c12c53)

Does it add value? I don't think so. Also, if we do it for mvc, we need to same on lambda routes... which isn't as easy as MVC.

Guys, You need to stop accessing private fields in Java 17. Field must be public or you need a getter method.

@jhannes Look [here](https://github.com/jknack/handlebars.java/blob/master/handlebars/src/main/java/com/github/jknack/handlebars/ValueResolver.java#L87). It checks what Java version are you running and setup the value resolvers properly. This work: ``` Handlebars handlebars = new Handlebars(new ClassPathTemplateLoader()); Template tmpl = handlebars.compile("example.txt");...

Odd. We can probably add the `public` check on Java 14 or higher. But again, people need to understand this issue is part of upgrading to new JVM.

Field must be public in modern JVM. You can see the root cause here: ``` Caused by: java.lang.IllegalAccessException: class com.github.jknack.handlebars.context.FieldValueResolver$FieldMember cannot access a member of class java.lang.String (in module java.base)...

Right. Are you building with Maven? There is a maven profile for Java 15: https://github.com/jknack/handlebars.java/blob/master/handlebars/pom.xml#L381 The profile has the required dependency. Build is running without issue against Java 15. See...