Jesse Braham
Jesse Braham
Any updates on the S3 runner? It would be really nice to check at least one Xtensa target in HIL.
(Sorry I'm reading some material relating to contributing guides, will do a proper review within the next few business days)
Sorry for not getting to this, had a lot on my plate. I think we should meet as a team to discuss how best to move forward with this. I...
Not a huge fan of just panicking on invalid key length, as there's no way for an application to recover from that. I guess without `const_generic_exprs` there's not much else...
Thanks for the input @bjoernQ. Not quite sure what is best right now, I think making it fallible or the key size enum are both probably fine solutions. So, no...
I've suggested a solution, so has Bjoern. I'm not going to be too picky about what we decide on as long as it doesn't just panic. If nobody else has...
> I think, as `Key` enum is currently a "nicest" solution, we can proceed with it 🤔 Sure, that's fine too. A fallible API is probably simpler, though.
I do not think the generics are especially useful (and get in the way more than anything). I've been of the opinion that our GPIO driver needs a full redesign...
Once https://github.com/esp-rs/esp-hal/issues/1063 is resolved we can revisit this issue.
Thanks for the PR. We're still discussing what we're going to do regarding the various `embedded-hal` traits, so I'm hesitant to start refactoring our drivers specifically to accommodate them. Assuming...