Jacob MacDonald

Results 1148 comments of Jacob MacDonald

I have mentioned this elsewhere but worth mentioning here for posterity - build_runner uses dart:mirrors in order to discover all of the libraries that exist in a program. In our...

> If I use reflectClass(SomeClass) , my whole codebase can still be tree shaked, minus that specific class. Not with the current `dart:mirrors`. From a single `ClassMirror` you can reach...

@gmpassos I very much agree with you :). I have even hand coded something to mimic a theoretical "const reflection" proposal in this package https://github.com/jakemac53/static_reflection (sorry for lack of readme...

@labaxter This is a bit off topic but you should be able to use `json_serializable` on all platforms without doing any copying around of files or anything like that -...

> This also feels pretty bad, in my opinion. Maybe this is a pub issue, but it sucks that I wont be able to get full pub points for my...

We used to have `Dart Native` as a platform, so that at least it would show up as a valid use case? The current thing is way over indexing to...

@isoos https://pub.dev/packages/build_runner/score is an example of this, previously we at least only got partially dinged for not supporting the platforms that made no sense to support with a command line...

Note that this should probably be fixed because the cast inserted is actually unsound, not just ugly. It will cause problems when enabling sound null safety, repro example: ```dart void...

Fwiw, this does occur with other generic types other than `String` as well. These are generally responses from some API from what I have seen, and often have the word...

Actually, I would wager that the significant majority of casts to anything with a specific generic type are invalid. I have seen similarly invalid casts to types like `Iterable` etc...