Jacob Langley

Results 6 comments of Jacob Langley

For what its worth, it may not be possible to do this in CMAKE right now. From CMAKEs documentation here: https://cmake.org/cmake/help/latest/manual/cmake-cxxmodules.7.html "Header units are not supported."

I tried this set of minimum repro steps based on the info here and couldn't repro the failure either. ``` C:\Users\jacobl\source\repos\SafeInt>type example.cpp import "SafeInt.hpp"; int main(int argc) { SafeInt x(argc);...

Aha! Changing the safeint type to `unsigned int` did the trick: ``` C:\Users\jacobl\source\repos\SafeInt>type example.cpp import "SafeInt.hpp"; int main(int argc) { SafeInt x(argc); return x; } C:\Users\jacobl\source\repos\SafeInt>cl /std:c++latest /nologo /Wall /wd4668...

Sorry for the delayed response. I'm actually working on adding the `static_assert` that things aren't an enum to every location where `numeric_limits` is used in our local copy already so...

The static_asserts seem completely fine to me. I know we compile and validate now with static_asserts in place and had only 2 places where we hit this issue. It's pretty...

thanks github for not showing me that PR response before I replied. As soon as that hits master I'll look at removing our changes for this issue and moving to...