Jacob Roberts

Results 43 comments of Jacob Roberts

Request to get this change merged upstream

Perhaps unnecessary, but it does reflect the real history of the changes. I would say look at the discussion on the various approaches in [this SO article](http://stackoverflow.com/questions/7947322/preferred-github-workflow-for-updating-a-pull-request-after-code-review). Would you suggest...

@effigies all the pre-release tests failed for the same reason -- a string representation in a doctest for `netcdf_file`. I don't immediately see how my changes would have introduced this....

Trying to narrow differences... since `mmap` is coming from the standard lib I suspected a change in Python versions and how `repr(mmap_obj)` or `str(mmap_obj)` is displayed... Its possible, though still...

Another fix I tried but seems the compiler is not smart enough to know about the elimination of the potential void type: ```typescript interface TypedRequest extends express.Request { body: ExtractRuntimeType;...

This works: ```typescript interface TypedRequest extends express.Request { body: ExtractRuntimeType; params: Tuple2Dict; query: T['query'] extends void ? {} : NonNullable; } ```

I was able to reproduce the issue in the test suite, but not minimally so (yet). I’ll try and file a PR at some point in the near future

@hmil Could use your help here.... Essentially, it seems like the underlying types in the upstream @types/express repo have changed, and that is what was needed to get a minimum...

@Ali-Parandeh can this be closed now?

We can probably add this to the matrix proposed [here](https://github.com/RobertCraigie/prisma-client-py/pull/521/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88R258) and pass that through as a build arg to the `OS_DISTRO` [here](https://github.com/jacobdr/prisma-client-py/pull/1/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557R2) to exercise this as a test case (in...