Jacob Roberts
Jacob Roberts
@samwillis I would feel comfortable taking this on once we have the CI setup in place so that we can use docker to emulate the OS environment reported by @njzjz
I think this makes a lot of sense and KISS in terms of keeping track with the upstream project more easily which is pretty NodeJS-centric. Question: why not make the...
Something somewhere is choking on the installation via `.[node]` expecting `npm` and `node` on the PATH. Need to track that down a bit more ```bash [email protected] /home/prisma/.local/lib/python3.10/site-packages/nodejs/lib/node_modules/npm prisma@c7ca946a4a90:~/.local/lib/python3.10/site-packages/nodejs$ /home/prisma/.local/lib/python3.10/site-packages/nodejs/bin/node /home/prisma/.local/lib/python3.10/site-packages/nodejs/lib/node_modules/npm/bin/npm-cli.js...
Update to the above -- its coming from the `@prisma/engines` somewhere, but still need to track that down even more: ```bash ~/.local/lib/python3.10/site-packages/nodejs$ /home/prisma/.local/lib/python3.10/site-packages/nodejs/bin/node /home/prisma/.local/lib/python3.10/site-packages/nodejs/lib/node_modules/npm/bin/npm-cli.js install @prisma/[email protected] npm ERR! code 127...
Actually, I think its really coming from the @prisma/client dependency: ```bash DEBUG=* python -m nodejs.npm install --foreground-scripts @prisma/client sh: 1: node: not found npm ERR! code 127 npm ERR! path...
Fair enough re: your point above **but** if someone does not have NodeJS a first-time user is going to have a worse experience with a pip install. Also, anyone who...
@RobertCraigie I know you still have some TOODs but thought I would leave an early review. Let me know when you think this is ready for me to check out...
Interestingly, we actually don't need the node dependency at runtime, right? Not to throw more confusion into the mix, but at "production" runtime (not dev) I believe we only need...
@RobertCraigie I think we can close this now as the associated PR has been merged
Unless we want to keep this open to track full compatibility with upstream errors