Wing Chau

Results 16 comments of Wing Chau

Hi @rishabh-bector, can you list out the details of your dev environment? And were you building Windows app or for other platforms? I haven't used the template with WSL before...

> a hot reloader would be amazing Do you mean to auto reload the main process? Coz I believe the renderer process is already reloadable if you use the command...

> > Do you mean to auto reload the main process? Coz I believe the renderer process is already reloadable if you use the command `npm run dev` to start...

> > is this issue is fixed in XCode 12.3 ? Because I do not want to download 2 versions of xcode just to get VIM running. > > It...

> Thanks for repo. Easy to fix. Change your test file like this: > > ```diff > import { jest } from "@jest/globals"; > - import { BrowserWindow } from...

I agree that it’s probably better to import CJS modules by using `required()`. Perhaps we should update the [ECMAScript Modules](https://jestjs.io/docs/ecmascript-modules) to include things we discussed here so there’s less confusion...

> @iamWing Good idea. I think it would be great to add an example with `jest.unstable_mockModule()` (see https://github.com/facebook/jest/issues/10025#issuecomment-1016690087) and your case with `electron` to ECMAScript Modules guide. Perhaps a link...

> Agreed (; Are you up to opening a PR? @mrazauskas sure. Let's see if I can find some time to make it later this week.

> > @mrazauskas Thank you! That got me moving. I guess `unstable_mockModule` is undocumented, but needed instead of `.mock()` for ESM modules? I found the PR where it was added;...