WonChul Heo

Results 112 comments of WonChul Heo

Do you have loadmap this issue? 🤔

In the long run, I think Proposition 1 can be inefficient. So I like suggestion 2 more. 👍

This issue is a fixed issue in master branch. Manage your `.yml` files separately. Each language's library does not always support it.

I've analyzed this briefly. However, I haven't been able to find a solution, but I'd like to share an interesting fact. This is first executed by `SpringApplicationShutdownHook`. And in the...

> @heowc Any other comments? 😊 I have not received any feedback on this comment. WDYT? 🤔 https://github.com/line/armeria/pull/4435#discussion_r979190256

> @heowc Do you mean changing the media type of the response? Including the media type I thought the user should get a separate desired response. ex) media-type: text/plain body:...

> That sounds good. Because this PR is merged we need to create another PR. Do you mind sending it? 😆 let's create an issue for tracking.

I'll work on it. I think I can solve it by creating a class like `AbstractHttpHeaders`. And I need to check a little more detail. 😄

I was readed code about `DefaultHttpHeaders` and `ReadOnlyHttpHeaders`. So, I thought about creating the following code from `HeaderUtils`: ```java @Nullable public static HttpCookiePair getCookie(Iterator iterator, Predicate predicate, final CharSequence name)...