hack3r-0m

Results 18 comments of hack3r-0m

@frangio is it for `ERC20Votes` ? (https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/extensions/ERC20Votes.sol#L144 ) I can add documentation for it, compound published good article on it https://medium.com/compound-finance/delegation-and-voting-with-eip-712-signatures-a636c9dfec5e

does this proposal concern only with providing the ability to create multiple choice proposals or also with the nature and interpretation of the options/choices (for e.g if a proposal has...

is CHANGELOG entry required for documentation edit?

thanks @Amxx, i have documented `version`, regarding example, how comprehensive it should be? should it use `ethereum-js` utils or `ethers` or `web3`? similiar to https://gist.github.com/ajb413/a5466a61558c0897491c378ce6682ad0#file-delegate-sign-js with version in domain seperator...

thanks, @Amxx, version should be `1.0.0` or `1` while adding examples into docs? since https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/extensions/draft-ERC20Permit.sol#L36 uses `1` while the one you mentioned uses `1.0.0` [official eip](https://eips.ethereum.org/EIPS/eip-712#specification-of-the-eth_signtypeddata-json-rpc) too does have any...

I have also replaced `deadline` from the above example with `expiry` to match the type's attribute. ![image](https://user-images.githubusercontent.com/54898623/147008172-e0ccdf98-cdc2-4602-b3db-ec726baf092b.png)

A better solution would be to create a new library `CounterExtended.sol` which will not break existing apis.

@bmancini55 I want to work on this issue, `@node-lightning/bitcoin` does not contain `Bech32` class