Greg Hesp

Results 82 comments of Greg Hesp

> Use this code to support both. > > ```ts > const picture = this._config.use_entity_picture > ? entity.attributes.entity_picture || entity.attributes.image > : undefined; > ``` > > > Any suggestions...

> Hum, may be HA doesn't expose the min/max attributes and just use it to compute the state 😢 Hopefully not, otherwise it's somewhat pointless, although maybe thats why the...

Updated so that no min/max values are provided through the card itself. Instead, they need to be added through the customize section of `configuration.yaml`: https://github.com/greghesp/lovelace-mushroom/blob/plant-card/.hass_dev/configuration.yaml#L10

Should be ready for review now :)

@piitaya Ready for review now

HA doesn't expose an `entity_picture` for `plant`. By default, the plant card will use an icon defined in the card config, and pull in the data from the default plant...

> I'm speaking about the `limits` fields. I'm not sure it will be under `limits`. I think we can directly add the `min` `max` attributes at the root level. Ah...

> There are also conflits with the `colors.ts file`. Entity related colors moved to `theme.ts`. I'll take a look at this. Need to get familiar with it :D

@piitaya Merged with main and updated. > Also, there is hardcoded hexa code in the `css`. It can be good to use css variable to support theme. But I can...

I made a PR for the core `plant` integration to expose the min/max values as limits, which would also remove the need for customising the devices: https://github.com/home-assistant/core/pull/71514