Graham Christensen

:+1: thanks! Probably the next step is looking in to dbix::class for pre-save/pre-create validation hooks. I'm not sure if it supports them, but that would be the ideal fix. If...

Beyond the merge conflicts present, I think this PR would be easier to review and merge if the validation of the data and fields were its own function, with tests...

Probably a good idea to make it a separate PR, even though I'd like to merge this one soon too! On March 11, 2021, GitHub ***@***.***> wrote: > @grahamc Since...

I pulled the fix for #889 out in to https://github.com/NixOS/hydra/pull/891, since I'd really like to see the validation here made in to its own function.

Looks good, can you document this option? One caveat here is users need to be very careful that the build machines do not substitute from a caching proxy. For example,...

The main hydra should also not point to the cache :).

Maybe start an (anemic) section here for "queue runner settings": https://github.com/NixOS/hydra/blob/master/doc/manual/src/configuration.md#statsd-configuration ?

Well, it would be _amazing_ if you made a passing note of each of those. _And_, I'm not going to block this PR on it.

To fix this we'll need to identify the name of the branch that has been fetched. This is because the name of the branch is an input to the evaluation,...

Interestingly, almost none of this strictly needs to query hydra. For example, the client itself could do the evaluation and check the cache to identify popular missing store paths from...