hydra

hydra copied to clipboard

• Document the fields
• Default most fields
• Mostly validate fields
• Allow rich values for enabled and type
• Print all errors instead of only the first

Errors look like this:

Beyond the merge conflicts present, I think this PR would be easier to review and merge if the validation of the data and fields were its own function, with tests written to cover at least its most important cases.

I've rebased the rest of it (docs, the migration) in the attached patch, hopefully that helps: 0001-Partially-rebase-814-to-master.patch.txt

cc @grahamc as your watch was probably dismissed by me marking this PR as a draft

@grahamc Since this also fixes a bug I introduced, do you want me to make a PR with only that bugfix so it gets to master faster or does this have the change to be merged soon?

Probably a good idea to make it a separate PR, even though I'd like to

merge this one soon too!

On March 11, 2021, GitHub @.***> wrote:

@grahamc https://github.com/grahamc Since this also fixes a bug I introduced, do you want me to make a PR with only that bugfix so it gets to master faster or does this have the change to be merged soon?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NixOS/hydra/pull/814#issuecomment-796654615, or unsubscribe <https://github.com/notifications/unsubscribe- auth/AAASXLDGLTXU5WSMSBC5XZDTDCPRPANCNFSM4RKXN5TQ>.

I pulled the fix for #889 out in to https://github.com/NixOS/hydra/pull/891, since I'd really like to see the validation here made in to its own function.