Pavel Vazharov

Another question about the behavior of unexpected_event<_> vs unexpected_event<some_event>

2

Hi, In the below code if the line with 'unexpected_event' is used the program prints guard1 go_to_s1 which is expected (IMO). However, if instead of this the line with 'unexpected_event'...

Hi there, We have transparent HTTP forward proxy which runs on standard Linux. However, we are trying to find more performant alternatives. We would like to test/benchmark the yastack/envoy-proxy when...

It seems to me that the counters in utp_context_stats needs to be bigger than uint32 (the current type). I was playing with a seeding application using the libutp. I noticed...

Proposition for removing the global suppression `-Wno-stringop-overflow` from the build

1

Hi there, As far as I checked the only place where this warning is raised is here: ``` /z/x3me-ocn/src/iocore/net/OCSPStapling.cc:1166:12: warning: ‘char* strncat(char*, const char*, size_t)’ specified bound 1 equals source...

Pass url_len when emplacing in Http2CommonSession::_h2_pushed_urls

4

The signature of the function in question is ``` void Http2CommonSession::add_url_to_pushed_table(const char *url, int url_len) ``` The given `url` is used when emplacing/inserting to `_h2_pushed_urls` collection but the given `url_len`...

Is this missed to pass argument in `plugins/multiplexer/dispatch.cc`?

1

Hi there, There is [this `read` function](https://github.com/apache/trafficserver/blob/master/plugins/multiplexer/dispatch.cc#L133) in `plugins/multiplexer/dispatch.cc`: ``` uint64_t read(const TSIOBuffer &b, std::string &o, const int64_t l = 0) { TSIOBufferReader reader = TSIOBufferReaderAlloc(b); const uint64_t length =...

Is there interest to get rid of `-Wno-unused-parameter` warning suppression?

1

Hi there, So, I did the above experiment for myself and there are lots of places which need to be fixed. However, the warnings also revealed few places with potential...

Is this missed to forward argument in `Http2CommonSession::add_url_to_pushed_table`?

1

Hi there, The `url_len` argument of `Http2CommonSession::add_url_to_pushed_table` [function](https://github.com/apache/trafficserver/blob/d31a40fecb19f80ae8b7ddbb2ff0efecc57bf7f9/src/proxy/http2/Http2CommonSession.cc#L459) is not passed to the `emplace` call. ``` void Http2CommonSession::add_url_to_pushed_table(const char *url, int url_len) { // Delay std::unordered_set allocation until when it...

Hi there, There is [this function](https://github.com/apache/trafficserver/blob/d31a40fecb19f80ae8b7ddbb2ff0efecc57bf7f9/plugins/header_rewrite/matcher.h#L189) and it has the following signature: ``` bool test_reg(const std::string &t, bool nocase = false) const ``` However, it seems to me that the...

Hi there, [This constructor of LogField](https://github.com/apache/trafficserver/blob/master/src/proxy/logging/LogField.cc#L330) takes `SetFunc _setfunc` but it doesn't set its member `m_set_func` to it. Instead it sets `m_set_func(nullptr)`. The passed `_setfunc` is unused in this function....