Philip Jägenstedt

Results 1054 comments of Philip Jägenstedt

> Fullscreen inside of `` should have been forbidden by the "allowed to use" algorithm anyway. Right, but it [used to work](https://chromium.googlesource.com/chromium/src/+/32a059337eb1c538242091adc170c41be325443b), is all, which just means that whatever the...

Aligning on Edge's behavior makes good sense to me. I think these are the bits in HTML that would need calls to this spec: * opening a popup: [window open...

FWIW, the main compat risk I see with this is that people might call `video.requestFullscreen()` + `video.play()` in the same event handler, and that consuming the gesture will mean the...

Right, as long as no two APIs that consume user activation make sense together, then it can be avoided.

@mustaqahmed is there an existing spec concept that can be referenced to produce a PR for what this change would be spec-side?

I see, so the concept would be "consume user activation" which takes a window. Then the spec change would be to just do that somewhere in https://fullscreen.spec.whatwg.org/#dom-element-requestfullscreen, would it be...

@mustaqahmed I put together https://github.com/whatwg/fullscreen/pull/153, preview at https://whatpr.org/fullscreen/153.html#dom-element-requestfullscreen. I put the consume in the sync part of the algorithm. This does mean that there are some error conditions which will...

This situation is accounted for in the Chromium codebase, with the comment "We may have entered fullscreen mode without changing our size." here: https://cs.chromium.org/chromium/src/content/renderer/render_widget.cc?sq=package:chromium&dr=CSs&l=1233 In this situation, no resize event...

This may be a spec bug, because it uses the style `position:fixed !important`. @upsuper, this issue looks related to https://github.com/whatwg/fullscreen/issues/19, perhaps you have some ideas?

Continuing from https://github.com/whatwg/fullscreen/pull/87#issuecomment-301755115 Does that "revert the window state" appear as a step of one of the spec algorithms, or is it something that happens after the spec algorithms have...