Philip Jägenstedt
Philip Jägenstedt
@KyleJu have you worked on the autocomplete feature at all, or is this all untouched since Luke implemented it?
My first guess is that it has to do when this line of code is reached (or not): https://github.com/web-platform-tests/wpt.fyi/blob/f1085b05b601f65b4d171e022433723bd39307b3/webapp/components/test-search.js#L555
Do you mean that it doesn't matter what version of go and node I have locally (or in a local container) when deploying, that nothing other than `gcloud app deploy`...
I filed this because it would have come in handy for https://github.com/web-platform-tests/wpt/issues/26326.
This keeps happening and I wanted to report it again before finding this issue :) Today it's https://github.com/web-platform-tests/wpt/pull/24660/checks?check_run_id=887477796 where the links are missing. The links come from https://github.com/web-platform-tests/wpt.fyi/blob/master/api/checks/summaries/templates/_pr_runs_links.md, which is...
OK, the logo is explained by this: https://github.com/web-platform-tests/wpt.fyi/blob/1eff5084b5f85d14cdda1dbe74d7f41eb10a59e3/webapp/components/product-info.js#L158-L160 This was added in https://github.com/web-platform-tests/wpt.fyi/pull/2100. So we use the Chromium logo when the nightly label is used, because it actually is Chromium....
It sure looks like we're running this configuration every day: https://wpt.fyi/runs?label=nightly&label=master&max-count=100&product=chrome But I'm struggling to find where it's triggered.
I think there are multiple issues here. One is what we should do with missing tests in the general case. We currently show those as "0 / 1" when summarized,...
You can actually see the rename detection kick in if you reload the page. It happens async so first you get a glimpse of the original state of things. @jgraham...
Would this mean fixing up the URLs automatically when possible?