wpt.fyi

wpt.fyi copied to clipboard

Check

https://github.com/web-platform-tests/wpt/pull/10571/checks?check_run_id=268068852

Description

This check includes a very useful "Latest results for PR #10571" link. However, on many checks I look at that link is missing, and I miss it. Example: https://github.com/web-platform-tests/wpt/runs/265894206

This keeps happening and I wanted to report it again before finding this issue :)

Today it's https://github.com/web-platform-tests/wpt/pull/24660/checks?check_run_id=887477796 where the links are missing.

The links come from https://github.com/web-platform-tests/wpt.fyi/blob/master/api/checks/summaries/templates/_pr_runs_links.md, which is included in completed.md and regressed.md. However, there's no conditional, just the range $pr := .CheckState.PRNumbers in the template.

Peeling off a few layers, I think the PR numbers come from: https://github.com/web-platform-tests/wpt.fyi/blob/cc5c6817f76446b0bf2012cec67ce48d3850b574/api/checks/webhook.go#L120-L137

I haven't looked at any webhook payload, but have to suspect that the difference is between what information we get in "requested" and "rerequested" actions.

@Hexcles I can't see that this issue has had any labels added or anything, can you triage it?