Frode Flaten
Frode Flaten
3 years later, status? String vs attribute? Both? String is cleaner, but no way to identify type name from real class (use cases?)? Also inconsistency with parameter-attribute. Accepted extension for...
Isn't it about time that we change this to `_nextAvailableParameterSetIndex == 32`, `_nextAvailableParameterSetIndex > Math.Log2(uint.MaxValue)` or something similar and actually throw the exception? 🙂 https://github.com/PowerShell/PowerShell/blob/65b83e90d5ee79464dba0dc2b41d3da38c4f8d5c/src/System.Management.Automation/engine/MergedCommandParameterMetadata.cs#L231-L241 > I agree there should...
It's a breaking change. `ls $nonExistingVar` in bash and `dir ""` (not entirely the same) in cmd behaves the same.
Similar to #17694. `newManifestInfo` already contains `PrivateData` -> `Tags` when this is executed: https://github.com/PowerShell/PowerShell/blob/a468fb1f499f5f6f1468571df76b50e85c9f4b39/src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs#L3232-L3236 Obvious solution is to clear `Tags` first with an internal method, but it's a bit brute-force....
Maybe include `true` per project or in a `Directory.Build.props` in the root so we can compile for Windows. Had to use that to catch all errors in #17769.
> @fflaten I don't think windows containers are supported for either devcontainers or codespaces? Not Windows containers, but being able to run `Start-PSBuild -Runtime win7-x64` in Ubuntu container. Without that...
Feels like random failures. Rerun?
Just noticed that #17684 plan to replace this code. This PR can be closed if the other one is accepted.
Tested devbuild with vscode-powershell (stable). It also shows filtered values as expected.
> I suggest to put enum value list and code to check range in ValidateRangeAttribute class. I agree on the validation. Just realized that I forgot about rangekind also Initially...