Aleksi Pekkala

Results 47 comments of Aleksi Pekkala

@afilipovich your replacement for the `_SB.PCI0.LPCB.EC0.SFNV` call works on my UX310UQ too, thank you very much! Changing the thermal tipping table values however seems to have no effect - perhaps...

Following the instructions above I found another table at `0x597...0x59e`. Tinkering with the values didn't have any effect on the fan though (even after waiting for a while). I guess...

> struggling with adding token auth to the endpoints. Hi, was the problem including the `security` definition on operation objects? ```json "security": [ { "basicAuth": [] } ] ``` We...

Just a heads-up, `routing-controllers-openapi` now supports [class-level decorators](https://github.com/epiphone/routing-controllers-openapi#class-openapi-decorator) which helps to reduce duplication in cases where e.g. each method needs an identical `security` definition.

@endel should I rebase this against https://github.com/colyseus/colyseus/pull/452? The test mocks need updating to handle `ioredis`.

Thanks @endel! Now pointing to `ioredis`.

There's no place to define `description` and `example` out of the box, that's correct. Couple of ways around this come to mind: **using QueryParams/Params etc instead of QueryParam/Param**: ```typescript class...

No plan, no. Try one of the workarounds outlined above or submit a PR!

Hi! That's a good point, IsOptional should indeed add a null schema as well as remove the property from the `required` array. And yes, as `class-validator` uses `ValidationTypes.CONDITIONAL_VALIDATION` for both...

@loban that's totally reasonable, but the way `@IsOptional` is implemented is that it > Checks if given value is empty (**=== null**, === undefined) and if so, ignores all the...