Joe Tsai

Results 341 comments of Joe Tsai

Now that cmp has been available for a few years and there's been more experience with it. Is this option something still worth providing?

Thanks for the reference. I'll scan all usages of `cmpopts.SortSlices` within google and also in the public module proxy and see how often `SortSlices` is applied on a type that...

I was thinking about this more and I wanted to note a complication with generic less functions. Suppose you had: ```go type S struct { F1, F2 int } var...

Another subtle complication: it's possible today that `cmp.Equal` can break the transitive property that one would normally expect for equality. That is, if `a == b` and `b == c`,...

Feel free to mail out a PR fixing this.

Thanks! Can you `go fmt` the source files and update the PR?

A problem with PackagePrefix is that it assumes that package paths are universally stable. There are two failure cases I can think of: * A type is moved out of...

Apologies for the flurry of changes; was struggling to find a good name. I settled on `AllowUnexportedWithinModule`. A module is defined as "a collection of related Go packages that are...

#53 proposed adding `IgnoreUnsetFields` for a similar use-case, but I rejected my own proposal. It's possible that we can add `IgnoreFieldsExcept`. However, I would like to think through more carefully...