Joe Tsai
Actually, the `EqualFunc` feature can do something that my proposal can't do. In #28, Bryan suggested that we "discard all values that are *equal* to the zero value, not just...
> Are there actual examples that have come up in practice where the current API falls short? Yes. All three examples in the description were driven by real cases. The...
It's a large benefit that generally the ordering of options do not matter and that I don't need to think about it. In a sense, all `FilterPriority` does is allow...
(I'm not resurrecting this PR yet) Note to self: Think carefully about whether `Default` is only applicable for the immediate closing `FilterPriority`, or is applicable regardless of the number of...
In issue #75, we discussed how `func(cmp.Path) bool` and `func(interface{}) bool` doesn't compose well. Given `PathNot`, you would also define `ValueNot` for symmetry. However, `PathNot` and `ValueNot` do not compose...
For Bool, Int, Int8, Int16, Int32, Int64, Uint, Uint8, Uint16, Uint32, Uint64, Uintptr, the comparison is obvious. For Float32 and Float64, we [have to handle NaN](https://github.com/golang/go/blob/3caa02f/src/sort/sort.go#L283), but that's trivial. For...
I've commented on the PR with my concerns, which can be summarized as: * I'm concerned that it is too easy for `cmpopts.SortSlices(nil)` to conflict with other options that operate...
I feel somewhat strongly about making the helpers have some form of implicit type filter. My experience with `cmpopts` inside Google is that users don't give enough thought to which...
The consistent style so far is: * Anything that starts with an "Ignore" prefix is wrapping a `cmp.Ignore` (e.g., `IgnoreFields`). * Anything that starts with an "Equate" prefix is wrapping...
> The other thing I'd add is that objects within a slice need not be comparable (i.e. less function doesn't necessarily have to be defined), they only need to be...