Trevor Hartman comments

Results 165 comments of


                                            Trevor Hartman

Replace `sed` in favor of a simpler `replace` string that works like `clojure.string/replace`

I often manually test commands in Slack as the last step but agree some test automation would be a little easier.

Replace `sed` in favor of a simpler `replace` string that works like `clojure.string/replace`

@PabloReszczynski I'm tracking the issue to improve command testing in https://github.com/yetibot/yetibot/issues/745 FYI! I have a bit of untangling / decomplecting to do to get it working so it might take...

Replace `sed` in favor of a simpler `replace` string that works like `clojure.string/replace`

Hey @PabloReszczynski check out a sample of the data returned so far: https://github.com/yetibot/yetibot/issues/745#issuecomment-429120367 How does that look for improving testability of commands?

Replace `sed` in favor of a simpler `replace` string that works like `clojure.string/replace`

Yeah, it seems awkward to embed a Clojure function in a Yetibot command, so I would skip that. But regex would be fine I think. I'll add some example usage...

Replace `sed` in favor of a simpler `replace` string that works like `clojure.string/replace`

Hey @PabloReszczynski, any other questions? I needed this feature the other day so came back to see if you were blocked on anything 😁

Add a `-v` flag to `grep` for inverted match

Awesome 🚀

screenshot <url>

Problem is you'd need to be running a local browser alongside yetibot. Doable but complicates YB deployment. Better if there was a web service that did the capture for you.

screenshot <url>

This can be implemented as an alias: ``` screenshot # alias for json https://api.microlink.io?url=$s&screenshot | data $.data.screenshot.url ``` Or we could build it in.

Fixup Slack reconnection logic

Thanks for reporting @cvic. It looks like the main problem is trying to ping on a closed connection. I can handle that and mark the conn as closed to prevent...

a way to remove keys on 'my' command

Good thoughts. At one point I considered settings that were specific to the user AND the channel. Just not sure if we need that level of granularity. `!deploy app to...