dcodeIO

Results 453 comments of dcodeIO

Attempted to make a PR for it, but it seems the change has unforeseen consequences on other parts of as-bind that I do not yet understand. In case it's useful,...

Yeah, I guess we'll need some sort of code generation on the Wasm side eventually, though I imagine that this will then involve a transform of sorts to identify the...

When it comes to classes stuff becomes a bit more complex, yeah. The recommended way as of today isn't exactly ideal, which is to export the classes one needs to...

Regarding the example, the equivalent of what one could do currently with just the loader is: ```ts export class SaveState { // note the export gameboyMemory: Uint8Array; constructor(gameboyMemory): void {...

The code in question is here https://github.com/dcodeIO/bcrypt.js/blob/7e2e93af99df2952253f9cf32db29aefa8f272f7/src/bcrypt.js#L22-L34 where if the module is supposed to be run under Node.js, the `crypto` package is used to obtain proper random numbers. If running...

The following works as expected and does not return `true`: ```js var hash = bcryptjs.hashSync("something"); var result = bcryptjs.compareSync("something_", hash); console.log(result); // logs false ``` Note, though, that the maximum...

Seems that the library assumes a node environment, thus loading the `crypto` module to obtain secure random numbers, but actually isn't in a node environment.

So, part of the problem here seems to be that the module [attempts to require the crypto module](https://github.com/dcodeIO/bcrypt.js/blob/master/src/bcrypt.js#L25) first, expecting that it can catch the resulting error if this fails,...

minimal-env.js isn't actual code, that's a closure compiler externs file. Can you explain the problem you are facing in more detail?

That's strange, I've never seen a problem like this using any sort of IDE I use. Given that it's not feasible to delete the file as long as we want...