dash icon indicating copy to clipboard operation
dash copied to clipboard

Pattern tests and patches

Open anindex opened this issue 5 years ago • 1 comments

This PR includes the followings:

  • Functionality test for TilePattern, BlockPattern, ShiftedTilePattern, SeqTilePattern (excluding .has_local_elements() because it requires CartesianIndexSpace::includes_index(), which is not yet implemented)
  • Make typedef of DistributionSpec, TeamSpec, SizeSpec public for TilePattern, BlockPattern, ShiftedTilePattern, SeqTilePattern, CSRPattern, DynamicPattern and LoadBalancePattern.
  • Various bug fixes

anindex avatar Mar 18 '20 17:03 anindex

Codecov Report

Merging #700 into development will increase coverage by 0.81%. The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development     #700      +/-   ##
===============================================
+ Coverage        83.65%   84.46%   +0.81%     
===============================================
  Files              336      337       +1     
  Lines            24968    25362     +394     
  Branches         11354    11939     +585     
===============================================
+ Hits             20887    21423     +536     
- Misses            3692     3699       +7     
+ Partials           389      240     -149     
Impacted Files Coverage Δ
dash/include/dash/pattern/CSRPattern.h 88.37% <ø> (+15.69%) :arrow_up:
dash/include/dash/pattern/LoadBalancePattern.h 84.88% <ø> (ø)
dash/test/pattern/BlockPatternTest.h 100.00% <ø> (ø)
dash/test/pattern/SeqTilePatternTest.h 100.00% <ø> (ø)
dash/test/pattern/ShiftTilePatternTest.h 100.00% <ø> (ø)
dash/test/pattern/TilePatternTest.h 100.00% <ø> (ø)
dash/include/dash/pattern/BlockPattern.h 98.62% <100.00%> (+1.73%) :arrow_up:
dash/include/dash/pattern/BlockPattern1D.h 99.10% <100.00%> (+0.11%) :arrow_up:
dash/include/dash/pattern/SeqTilePattern.h 93.55% <100.00%> (+1.16%) :arrow_up:
dash/include/dash/pattern/ShiftTilePattern.h 88.23% <100.00%> (-2.20%) :arrow_down:
... and 51 more

codecov[bot] avatar Mar 21 '20 13:03 codecov[bot]