Daniel St. Jules

Results 35 comments of Daniel St. Jules

@TCB13 Awesome! :)

> Alright! My 3rd point was about the fact that "substringing" is very common when manipulating strings, that's why I expected these methods to be merged in the main library,...

@TCB13 Agreed! Building off the core methods can get verbose too for some of those operations as the array primitives in PHP aren't great. Definitely appreciate the library :)

Def agree. At that point, we need to decide whether or not to expose mb_ereg_match with its quirks and differences to preg_match

I'm just monkey-patching the method for now, but it would be great to see this change in passport-twitter!

Thanks for the issue! I'd recommend opening an issue with the assertion library (chai?) since they define `err.expected/err.actual`. For example, using just node: ``` $ cat test.js var expect =...

You're right! It was a bit late for me, so substitute diff with err.expected and err.actual - both are provided by the assertion framework. In this case, chai isn't giving...

Have you thought of recording example JSON API responses as fixtures? https://github.com/assaf/node-replay could help with that

Looks like this might be specific to windows? If you clone this repo and run `make test-all`, do tests fail? Updating `var slash` to be `path.sep` when `is.node` is true...