Daniel St. Jules

Results 35 comments of Daniel St. Jules

I think in the pursuit of eventually trying to keep the mocha core minimal, the team might be hesitant in introducing many new features. The next major release of mocha...

Just tested and it's still an issue: ``` javascript $ cat test.js var assert = require('assert'); it("A", function(done) { this.timeout(1000); setTimeout(function() { assert(false); done(); }, 2000); }); it("B", function(done) {...

Looks like it's been the same behavior for a while. Mocha assumes that cleanup couldn't be done properly if an exception was thrown from the afterEach hook. ``` bash #...

@boneskull In my first reply above, I went as far back as 1.16.2 (Dec 23, 2013). The behavior's been the same in 2.2.1, 2.1.0, 2.0.0 and 1.16.2. Unless it was...

@boneskull Because some assertion libraries do no throw instances of AssertionError (ex: expect.js). However, both chai and should do.

> detect an AssertionError as well if the object has actual and expected properties. If expect.js has these properties, we could just go w/ that. Good call. :) Had completely...

I think so. :) Given its scope, it'd probably have to be directed at the next major release (3.0.0)

I agree that'd be helpful :) So far, failures aren't generally obvious unless they're early in the suite: ![screen shot 2015-03-08 at 9 53 52 pm](https://cloud.githubusercontent.com/assets/817212/6550121/d9a6b07c-c5dd-11e4-8f19-33285a5bbb87.png) I'll a submit a...

Looks like there's multiple proposed forks! Hadn't realized PHP5 hit EOL (https://www.php.net/supported-versions.php) -- in this case it does seem like https://github.com/voku/Stringy is a good alternative! Would it be helpful to...

* Package renaming sounds fine, probably easier to remember as you said * Join sounds good 👍 * I don't think SubStringy belongs in the core, and could probably be...