Róbert Kalmár

Results 13 issues of Róbert Kalmár

…ned true Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following...

Currently there are many ways for the parse to fail. Making an aggregate error type we could avoid using ```Box``` and remove some awkward result building code.

Currently there are three versions of ```XmlNodeExt``` trait, one for each module. There should be only one available. Also unify ```impl XmlNodeExt for XmlNode``` in modules where there are no...

Logging is missing from a lot of places. All "from_xml_element" method should be logged with info! to allow easier debugging.

The GraphicalObjectData can hold any type of xml element. Try to figure out how this could be implemented.

enhancement

Same as with pptx module, the official documentation could be used extended with some extra information if necessary.

The pptx module basically has no unit tests. It should have at least the same amount of coverage as the docx module

enhancement

Instead of using `println!`, we should use the [log](https://crates.io/crates/log) crate. `from_xml_element` functions should start with a `trace!` to allow easier debugging in case of an error.

enhancement