Chris Smith

Reverting https://github.com/phpstan/phpstan-src/commit/b1fd47bda2a7a7d25091197b125c0adf82af6757 results in an error at the if statement: > Comparison operation ">" between 1|2 and 0 is always true. Which makes sense as the `array_pop()` now invalidates the...

Hah think I've just found this again. https://phpstan.org/r/eff591cd-41f7-4e5e-a236-f000f32236d5 Presumably this https://github.com/phpstan/phpstan-src/blob/e4b71d41de38a83ae4a9dcd2a9bdf342e10f3c3a/src/Analyser/NodeScopeResolver.php#L1849-L1878 should union on an empty array as that is a possible outcome of a `array_{shift,pop}()` call.

Basically the problem (using 2.12.0), by creating a new instance in a static method: > Avoid unused private methods such as 'doThing' ```php final class Test { public static function...

@GSpecDrum @oleg-andreyev I've raised a PR to add this feature as I've stumbled upon this error and with a large fixture set it's quite a frustrating limitation!

@julienfastre @axi @HeinDR I'm pretty sure the problem you're talking about is a different issue.

@dependabot rebase

Tested this myself, below is the `-vvv` output. I'm not sure I'd consider this a bug but a nice QoL improvement would be to just fall over before prompting for...

I'd appreciate some feedback on the behaviour change before I do any more work making this suitable to be merged.

> I don't know much about this bundle, but I don't see a problem with this, please go ahead. @greg0ire :+1: updated

> It seems there are CI jobs failing. Please take a look at [this guide](https://www.doctrine-project.org/contribute/#dealing-with-checks-and-tools) for more on how to handle those. PHPStan is failing but it seems to be...