Hideyuki Takeuchi comments

Repositories
Issues
Comments

Results 3 comments of


                                            Hideyuki Takeuchi

dayjs('2020-10-01').add(dayjs.duration(1, 'months')) not returns dayjs('2020-11-01')

### To reproduce ```diff diff --git a/test/plugin/duration.test.js b/test/plugin/duration.test.js index cca1a82..57456af 100644 --- a/test/plugin/duration.test.js +++ b/test/plugin/duration.test.js @@ -174,8 +174,8 @@ describe('Add', () => { test('Add duration', () => { const a...

fix: Duration.constructor()/toISOString()/add()/subtract() does not work properly

I will check why decreased the coverage.

fix: Duration.constructor()/toISOString()/add()/subtract() does not work properly

I found I enbugged another form of #1515 caused by tweaking internal representation in this PR. `dayjs('2020-10-01').add(dayjs.duration(30, 'days'))` returns `dayjs('2020-11-01')` I already fixed it at 09cd2dc.