Casey Connor

Results 32 comments of Casey Connor

Thanks Rohan -- first, I've been out of the email world for a long time, so I'm probably stuck in 2822 and haven't paid attention to the new RFCs, so...

> @chconnor Thanks for taking a look! I'll try to answer each of these: > Not sure if this was defined in RFC 2822, but in [RFC 5321](https://datatracker.ietf.org/doc/html/rfc5321#section-4.5.3.1.1), the local...

Oops, just noticing that your demo emails don't have comments in the local-part! Sorry. I think the issue is that we can't handle nested comments because of regex recursing issues......

Yep, [we can't do nesting of comments](https://github.com/bbottema/email-rfc2822-validator/blob/63c1b7c7017f41114588c9ad5b83d517c09ec716/src/main/java/org/hazlewood/connor/bottema/emailaddress/EmailAddressValidator.java#L64).

@bbottema Could [this line](https://github.com/bbottema/email-rfc2822-validator/blob/63c1b7c7017f41114588c9ad5b83d517c09ec716/src/main/java/org/hazlewood/connor/bottema/emailaddress/Dragons.java#L183) be why "John Smith" matched? My java regex chops are long gone, but does that line allow for matching mailboxName with an empty uniqueAddrSpec? I can't...

Oh, good. I was wondering why javax was validating it also. :-) Looks like you have a great library developing. There have been a few alternative libraries developed over the...

That address looks valid to me... maybe @bbottema will have a comment about why it isn't working.

[This line](https://github.com/bbottema/email-rfc2822-validator/blob/master/src/main/java/org/hazlewood/connor/bottema/emailaddress/Dragons.java#L101) has `\\[]`, should that be `\\[\\]` ? It's been ages since I was in this stuff, so just taking shots here. :-)

Hmmm... seems like an uncommented ] there would really throw a wrench in... I'm surprised it didn't matter...

Congrats! For when you return -- how about [the line before](https://github.com/bbottema/email-rfc2822-validator/blob/master/src/main/java/org/hazlewood/connor/bottema/emailaddress/Dragons.java#L100) -- shouldn't that dot be escaped? `\\.`