Chris Friedt

> @stephanosio I'll take a look if nobody else is working on it atm

@Jens-G @emmenlau - let me know your preferences. E.g. ensure all destructors are virtual, inline in `.h` vs in `.cpp`, etc.

I opted to only insert the virtual keyword for destructors in this PR for now. I know that @emmenlau also wanted to remove inline implementations that assign `default` in headers....

Sure - thanks for the feedback. There is one other change that I would need to do to upgrade the Thrift version used in Zephyr after this. That is, namely,...

@CJCombrink - my PR needs approval to run tests. Can you please approve? This change definitely looks cleaner without the `virutal ... override` destructors. I'm not 100% sure if the...

@Jens-G @emmenlau - any chance someone could approve and run tests?

Any idea whether those CI errors exist already in the main branch? Please let me know if there are any additional changes needed

Thanks everyone 🙏

The toolchain header `include/bits/gthr.h` was modified as follows: ``` #if _GLIBCXX___ANDROID__ #include #elif defined(__ZEPHYR__) #include #else #include #endif ``` The file `include/bits/gthr-zephyr.h` is a copy of the upstream `gthr-posix.h` with...

> @cfriedt is there any reason why this pull-req is not progressing forward? @ortogonal The biggest reasons are 1. Zephyr has no way currently to dynamically allocate a thread stack...