Clemens Brunner

Results 578 comments of Clemens Brunner

Alright, all of my files still work with this PR. In addition to comments already mentioned, I suggest that we make `open_xdf` a private function (i.e. rename it to `_open_xdf`)....

BTW, `test_load_from_memory` fails with a `KeyError` because `testfile` does not have an `"info"` field. This test works on master.

This looks like your file might be corrupted. Can you load other XDF files normally?

What do you mean by the MATLAB function read in the file? Didn't it throw the error you are mentioning? @tstenner do you know if there is a tool that...

What is the result of `pyxdf.resolve_streams()` on that file?

If you are still encountering this problem, please feel free to open a new issue (and ideally share the problematic file).

I agree that duplicating chunk reading is not ideal, but at that time it was the quickest solution, because I could use functions from an alternative XDF reader I'd written....

I'd make this optional so even if there is a use case you haven't thought about we have that covered.

@cboulay do you want to implement this (e.g. with a new parameter `sort_irregular=False`)?