Jordan Eldredge

Results 253 comments of Jordan Eldredge

Interesting! Looks reasonable, but are you able to validate this change on its own, or do we need the VSCode fix as well?

Thanks for the bug report @alex-statsig. Do you have any output logs before that? I'm particularly interested in output from when the LSP first starts. Could you clarify exactly which...

Still working on landing this. It looks like it's triggering a number of errors internally. Trying to figure out if this is because we're catching real errors (and if so,...

Sorry, haven't been able to revisit. Adding to my todo list for next week.

So we have many infractions in our codebaese today, and I don't see an obvious way to "fix" these issues at scale. Maybe we need a mechanism to selectively ignore...

Thanks! Would you mind applying this fix to https://github.com/facebook/relay/blob/ab7704db22d48d525ac4497ba0e7c609e9d1cfd8/website/docs/tutorial/queries-1.md? That's the actual source of truth for this doc.

Hey @eMerzh thanks for exploring this idea! I kinda love it! But I do worry that it may be prohibitively verbose for use internally. At the very least I think...

Another concern we'll need to address: Flow types are generated inside Flow comments, which can't have block comments nested within them. I'll see if there's a workaround here.

Another item to add to your test plan: Run the compiler in `--watch` mode and then modify _just_ a field description and ensure that artifacts which include that field are...