Jordan Eldredge

Results 253 comments of Jordan Eldredge

So, the bad update happens on the rollback in response to the mutation error. During the rollback, the optimistically added list item is removed. This makes sense to me >...

Ah yeah, I had forgotten that the implicit batching was dependent upon using createRoot. I can confirm that once I did that I also was unable to reproduce the issue.

Hey! I've just been super busy and there are some internal crates which need to be updated to work with these changes. Still on my list, and (as always) I...

If I understand correctly, fixing it here in the Relay compiler will also require all users to ensure they upgrade the graphql-js version imported by their Babel plugin? I believe...

I like 2, but I wonder about the performance implications. Would the Babel plugin need to shell out to the Relay compiler for each document? A variant of 1 would...

This program is for uploading files to an FTP server not for uploading files to GitHub. Could you explain what exactly your are trying to use git-ftp to do? I...

Thanks for continuing to work on this! 1. Can "Fix "goto references" for TerseRelayResolver" be split into a separate PR? 2. How could we add unit tests for this code?...

I've been able to get this working internally, which is rad! However, I noticed one case which does not seem to work correctly: ```typescript const UserProfile = graphql` fragment RelayReaderTestCreatesFragmentPointersWithVariableArgumentsUserProfile...

FYI the LSP crate has some other internal users which I will need to update to work with these changes. It's on my todo list for next week.

Thanks for the report. We currently expect all GraphQL results to be stable within a single request. GraphQL Spec presumably allows this degree of instability, so I see where you're...