Benjie comments

Results 1088 comments of


                                            Benjie

Ruru rendering issues

Are these Ruru specific issues, or are they issues in the upstream project GraphiQL? If the latter, please file there. It’s also common to use GitHub-flavoured markdown, which like this...

Handle trapping errors produced by sideEffect steps

Don't attempt any further work on this; the problem is deeper than I realised. I'm rewriting part of planning to handle it.

Handle trapping errors produced by sideEffect steps

I'm going to keep this open because #2114 doesn't fix/test exactly this issue, it fixes a related underlying problem. It _might_ fix this, but either way your test here will...

Handle trapping errors produced by sideEffect steps

I've rebased this on top of all the core changes, reverted the changes to dependencies/etc, changed `TRAP_ERROR_AND_INHIBITED` to just `TRAP_ERROR`, and have added another test case that tests treating an...

fix: add newline between parts when logging masked error

Yeah I tested it locally; it works well (though the output is a little long): ``` Masked GraphQL error (hash: 'D_lpZ-JKiyJeHeL-ewyTV8UU4gE', id: 'TKNHKATUD9') You've requested the 'throw' field... which throws!...

TypeScript regression: loadOne no longer inferring types

(This was working fine in previous releases of Grafast, in particular beta.8 I think worked.)

It should be possible to declare a shared `@ref` only in the base table when using relational polymporphism

I think what you're asking for is essentially inheritance. Interfaces in GraphQL do not perform inheritance - they just describe the interface that is expected, and it's up to the...

(v5) I'd like get a generic executor from `build.input.pgRegistry` inside a `makeExtendSchemaPlugin`.

I agree; pgRegistry should accept executors even before it accepts codecs; each executor should be named for itself; so you should be able to get `build.pgRegistry.pgExecutors.main` to get the main...