Benjie

Indeed any time you add a name to the GraphQL schema (type name, field name, argument name, directive name, enum name, etc) that name should come directly from an inflection...

@JoviDeCroock Please reply to this so I can assign you.

(v4.5.0-rc.0 is now out.)

You must be running Node v12 which is end of life at the end of this month. Please upgrade to Node 14 or higher. https://nodejs.org/en/about/releases/ https://node.green/#ES2020-features-optional-chaining-operator-----

Does this only happen on custom queries, or does it affect tables too? It's very hard to guarantee unique ordering with functions, and I'd recommend against custom ordering over large...

Can you add `ID_ASC` to the order list? That should make it unique (we do this automatically for table types, but not for functions because ordering in functions is expensive).

But if the ordering that you've specified _is_ unique, then this plugin needs to indicate so.

This one with a unique constraint would be unique, yes. Without wouldn't be. This is equivalent to just sorting by `FOO_ID_ASC` directly?

Basically the plugin needs to declare that the order is unique, like we do in core here: https://github.com/graphile/graphile-engine/blob/9dca5c8631e6c336b59c499d901c774d41825c60/packages/graphile-build-pg/src/plugins/PgOrderAllColumnsPlugin.js#L37-L39

Not yet, alas. I’m planning to write a plugin migration guide at some point and then hopefully the community can help port plugins 🤞