Anatoly Pashin
Anatoly Pashin
> The docblocks for the traits should not contain the all* or nullOr* methods as the traits do not handle them. Yes, but that's poor maintainability. I defined abstract __callStatic...
Oh, I didn't realize they are generated by script. Ok, it would be simplier to bring them back to Assertion class.
@rquadling moved them back and removed abstract method.
Traits can't have constants. On Apr 18, 2017 21:33, "Richard Quadling" wrote: > Nice. > > Can the const's be moved too? I'd go with a renumbering also so use...
Ok I moved traits to namespace Assert\Assertion. The only thing about consts I have on mind — they can be namespace constants and placed along with trait using it. Example:...
Moving constants out from `Assertion` class will break BC and all tests.
Had some merge/force push bug, now all is fixed. I didn't renumbered constants, jsut moved them.
OK, I moved `scalar` out to trait and make it use bool, string and number. Don't know if it's really good… Also for renumbering: I'm not sure how to do...