Alix Lourme

Results 90 comments of Alix Lourme

For understanding why a proxy, and linked with #1303, a WIP/draft of a future [template example](https://github.com/GroupePSA/terraform-aws-github-runner/tree/exemple-ubuntu-vpc-routed-proxy/examples/ubuntu-ghes-vpc-routed-proxy) of this use case.

@ScottGuymer: Sorry for my response delay, full time on a "logger problem" since ~10 days. > I would suggest adding in the configuration of the https_proxy to the user-data scripting...

Set to draft even if all checks pass, because when tested really after last `develop` merge, problem on `webhook` runner (even if not part of these changes): ![image](https://user-images.githubusercontent.com/2912441/147236420-a49427c4-85c6-41c7-a90a-1e341c859a49.png)

> Set to draft even if all checks pass, because when tested really after last develop merge, problem on webhook runner (even if not part of these changes) Due to...

@ScottGuymer : Happy new year ! I think have answered to all request/question. Don't hesitate for any complements if it is not the case.

@npalm / @ScottGuymer : Sorry to bother you or seems to be insistent, but what could be the following of this PR ? Currently its status is *Changes requested* but...

> I have done a more in depth review with a number more comments. > [...]. Just need to add a little more testing and completeness to it. @ScottGuymer :...

> @npalm what do you think? @npalm : I allow me to bump this request 😁.

> SonarCloud Code Analysis Failing after 39s — Quality Gate failed About: - [1 Bugs](https://sonarcloud.io/project/issues?resolved=false&types=BUG&sinceLeakPeriod=true&pullRequest=1256&id=philips-labs_terraform-aws-github-runner): False positive IMO, waiting SonarSource feedback (follow [typescript:S3001 false-positive when “delete” operator used on optional...

> "errorMessage": "ENOENT: no such file or directory, open '/var/task/bridge.js'", @npalm : Even `proxy-agent` dependency hasn't change, the *ncc* generation JS files result has change 😢. `contextify.js` file has been...