Alix Lourme

Results 90 comments of Alix Lourme

> Would the enterprise id also be present for orgs that are part of an enterprise on GH SaaS? > I presume so as I think you can create enterprise...

**NB**: Since runner **v2.282.0**, the `--pat` parameter has been introduced, helping to manage configuration of ephemeral runners (https://github.com/actions/runner/pull/660): ``` --pat GitHub personal access token used for checking network connectivity when...

This issue should stay opened IMO (PR will be provided once https://github.com/philips-labs/terraform-aws-github-runner/pull/1256 rebased).

> This issue has been automatically marked as stale because it has not had activity in the last 30 days Waiting about linked PR https://github.com/philips-labs/terraform-aws-github-runner/pull/1256

> This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs Waiting...

> This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank...

> This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank...

> As first minor review, perhaps `https_proxy` could be renamed `HTTPS_PROXY` for coherence in environment variables naming (even if proxy variables is generally named in lowercase): Done

> why did you only add the proxy to the runner lambda? And not to the other two? *[comment updated after initially missing the sense of question]* @npalm : The...

@npalm : Ready for review (basic unit tests added for AWS SDK v2 ; all AWS request API are not mocked).