Matt Kane

Results 162 comments of Matt Kane
trafficstars

@xavivars Yes, I think it's best to hold off on this until #25479 and the other state machine PRs are in. We can then see how much of this makes...

Hi @benmccann Thanks for the nudge on this. I don't think this is related to this issue (this about rewriting the CLI itself in ESM). However I am going to...

@danez that's related, but different. This issue is about auto-generated names, rather than user-specified ones

There shouldn't be a user warning. This isn't something they control. We should just ensure that they can't be created.

I would suggest Gatsby 4 with the beta plugin, Nuxt 3 and SvelteKit

My concern here is that different versions of frameworks require different versions. Could we read it from the framework's `engines.node` field, rather than the plugin's?

I guess we need to know before we install it, but we could just grab the framework's package.json before installing the right node version

As I understand it, we'd do it so we can automatically switch to a supported version. This is why we'd want to know the supported version _before_ running the install.

That sounds like the simplest solution. I can't think of a scenario where a new site wouldn't work with LTS, but if there were I think it would be rare...

@benmccann I made the same mistake, but unfortunately setting the env vars in framework-info _doesn't_ work. With the change of the default build image to Focal, we are at least...