Andreas Urke

Results 93 comments of Andreas Urke

@tdesmet We would like to include this in the upcoming release. Would you be able to address the comments before next week?

Apologies @tdesmet , could you squash the commits?

This comment might be helpful: https://github.com/contiki-ng/contiki-ng/pull/1877#issuecomment-1162889584

@alexrayne I notice you have included this PR in one of your branches - have you been testing it?

I did a _sanity check_ with two custom boards with cc1310, no issues.

yea, because of 1. Some platforms use different length for directory names and the struct that holds them. The problem is discussed here: https://github.com/contiki-ng/contiki-ng/pull/1502#discussion_r628521101. As mentioned there I suggest we...

@g-oikonomou :+1: https://github.com/contiki-ng/contiki-ng/pull/1585 Following the discussion and fixes in https://github.com/contiki-ng/contiki-ng/pull/1502#discussion_r645089921, it might be 4e07c47f20057827bec40a916a49584027e2e161 is ready as well (CI fails because of 621f6ee486b222375292a296a1477b016618baf7).

@jeppenodgaard You got something brewing here or should I have a stab at it?

I have not had time to look at this yet, but if true it might be so for more libraries as well, ref. the PR where it was introduced: https://github.com/contiki-ng/contiki-ng/pull/1705

Apologies for no review, I am travelling and will be for the next two weeks as well