Ariya Hidayat

Results 74 comments of Ariya Hidayat

For object rest/spread support in Esprima, please track https://github.com/jquery/esprima/issues/1588.

@Kegsay Note that there is no released version with that feature yet. You may want to keep an eye on https://github.com/jquery/esprima/issues/1749. In general, I believe it is worth stating the...

hmm, looks like we have to drop support for Node.js

> Oups, tests legacy 6.x also failing. Should we delete this too @ariya ? yes.

> The whole point of the dummy workflow is to be there as a safety net for cases when we skip the main one which is required. There is one...

> In this example (modification to both driver code and a Markdown doc), what happens if the actual driver tests fail? After some experiments, I got the answer to my...

Thanks for this new chart addition @morgan12! To make it easier to review, and also for completeness, it's always a good idea to include a sample query which can product...

> I made some updates. Let me know if you all like this version. Thanks @morgan12! While waiting for the review, can you sign the CLA? https://github.com/metabase/metabase/pull/21421/checks?check_run_id=6113091273

Hi @tolkushkin, thanks for the report. Did you try it on https://esprima.org/demo/parse.html to see if it works there? When I did that and use the following (note that I added...

This could be done using the [--tag feature](https://docs.npmjs.com/getting-started/using-tags) of `npm publish`. A good precedent to follow is [the daily development versions](https://libraries.io/npm/typescript/versions) of TypeScript, they are available as `2.2.0-dev.20170201`, `2.2.0-dev.20170131`, etc....