Antonio Nuno Monteiro

Results 226 comments of Antonio Nuno Monteiro

@hannesm did you run into any issues that this PR fixes?

This is not relevant anymore, especially after #121. `Ssl.create_context TLSv1_2` creates a TLSv1.2-only context. In addition, I'm about to open a PR adding bindings to `SSL_CTX_set_{min,max}_proto_version`.

I think it's a fair trade-off to require pkg-config. It's well-supported in the platforms I'm aware (OPAM, Nix) and other similar packages that bind to native require it. Any historical...

Thanks, took care of that in https://github.com/savonet/ocaml-ssl/pull/126

We don’t release to NPM anymore

https://github.com/ocaml/dune/pull/7734 provided a way to solve this e.g. in a musl+static switch by setting `PKG_CONFIG_ARGN` (in our example, to `--static`).

This looks like a good idea. However I'm currently rethinking what this library should be about going forward. Let's let this sit for now, but happy to see it done...

@den1k because of this issue? do you want to take it? should be pretty easy to fix. see https://github.com/ladderlife/cellophane/commit/316734ee9aa4c2d5e4730ab3b3249e90e91d9d5a

I suppose we can just rely on Om Next now that it has server-side rendering.

I don't necessarily recommend esy since it's seen very little development in the last few years. That said, I'm happy to look at a repro and try to provide guidance....