Antonio Nuno Monteiro

This broke some extension tests.

I'm in favor of this. I've been using OCamlformat in every project and I like not having to think about indentation. PR welcome.

It sounds unlikely that this branch would cause those warnings. Rather, they might be related to Melange, not the PPX.

https://github.com/mirage/ocaml-uri/pull/169

@bobzhang This is a good improvement, nicely done! I have a question that may be better converted to an issue in the BuckleScript repo. Would you consider changing the representation...

> It doesn't follow the principle of least surprise because now the string literals will be interpreted differently by the PPX based on where they appear on the AST. I'm...

haven't had a chance to review this yet. It's going to be a few more days.

My rationale for having a limited set of options for these default handlers is that you can always "jailbreak" by using your own `Tls_lwt.Unix.t`, check out this example https://github.com/anmonteiro/ocaml-h2/blob/fceaad2cfa198f090b47d6d72cb1c4ea9dee4a07/examples/alpn/unix/alpn_server_tls.ml#L29-L48

@kit-ty-kate can you test both my suggestions? I couldn't build this in nix without them

Hey @gasche, I believe the reason is that ppxlib calls `Parse.{implementation,interface}` directly without going through `Pparse`: https://github.com/ocaml-ppx/ppxlib/blob/main/src/utils.ml#L100-L103, though it does set `Location.input_name`, allowing your fallback to work https://github.com/ocaml-ppx/ppxlib/blob/455f21787ad52a32813a34538a4d493f8d3efc64/astlib/location.ml#L3