Ankush Menat

Results 180 issues of Ankush Menat

Replace (or drop?) https://siderlabs.com/blog/sider-review-is-shutting-down/

meta

gettext has lazy version, this is useful for storing messages / global variables which make sense syntactically but are problamatic at runtime because they are evaluated only once. Lazy version...

feature-request
good first issue

ref: https://github.com/frappe/frappe/pull/17511 and https://github.com/frappe/frappe/pull/17756 We now retain `data-` attributes but without including styles these aren't rendered as they'd be in respective editors. Two possible solutions: - Include styles - Transform...

bug

The most frequent suggestion for improving adoption is updating documentation - https://github.com/frappe/frappe/issues/16825 This is a (mega) issue for tracking all focused improvements related to the framework documentation. Edit the checklist...

There are some ERPNext specific roles in vanilla FW install, these don't make any sense in vanilla framework:

bug
breaking change

For 2 reasons: 1. It doesn't exist on postgres 2. since innodb is the default this key shouldn't appear in doctype schema files 😄 Example: https://github.com/frappe/frappe/blob/19fb8cd409ac32a18c53bcbcf650a5fbc1a87eae/frappe/email/doctype/newsletter_attachment/newsletter_attachment.json#L7 Probable change in this...

bug
good first issue

- [x] remove test Doctype from code https://github.com/frappe/frappe/pull/17598 - [x] Validate and warn if protocol expectations aren't met! - [ ] clearly document what parts of ORM work with virtual...

This should be handled by framework, currently this requires hacks like these: https://github.com/frappe/erpnext/blob/fe5cae9594b590ecfef67c5e7c8d3b41239fe90c/erpnext/setup/install.py#L43-L60

bug

This is not required, idk why we rebuild all pages on every migrate. Some kinda timestamp / hash based check can be added to avoid redoing same work over and...

enhancement
performance

Github's create release API supports use of their release notes generator by passing `generate_release_notes` boolean value. - https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes - https://docs.github.com/en/rest/releases/releases#create-a-release A separate API to generate notes is also available: https://docs.github.com/en/rest/releases/releases#generate-release-notes-content-for-a-release